-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Fleet recipes for default policy change #5281
Conversation
@naemono hi, I'm not sure what is wrong here, the build failed: https://devops-ci.elastic.co/blue/organizations/jenkins/cloud-on-k8s-pr/detail/cloud-on-k8s-pr/7918/pipeline |
@juliaElastic looks like we exceeded our disk quota in the GCP project the tests run in
|
@pebrc @naemono @david-kow tried these commands locally, but getting errors: I tested the yaml configs in my local kibana, and seemed to work fine.
|
run full pr build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM from a Fleet perspective
@juliaElastic I'm going to try and replicate the failures you're seeing, and I'll get back to you about this. |
docs/orchestrating-elastic-stack-applications/agent-fleet.asciidoc
Outdated
Show resolved
Hide resolved
…idoc Co-authored-by: Arianna Laudazzi <[email protected]>
I'm sorry, I ran into a large number of local issues yesterday trying to replicate this, I'm going to try again today. |
@naemono hi, any luck with finding out the root cause of this build failure? |
@juliaElastic I've actually had terrible luck replicating this, and am trying one more approach today. I'll report back, and sorry for the delays. |
Ok, I've finally had some luck replicating this, and I'll see if I can figure out the root cause. Sorry again for the delays.
|
run full pr build |
I think the missing piece was |
@juliaElastic I just ran a test locally, and saw it pass, so this definitely resolved the issue. Sorry for the amount of time again that it took me to replicate this. I learned some things about e2e testing during this, definitely. |
The build is passing, can someone approve to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nit: trim trailing whitespaces.
Co-authored-by: Thibault Richard <[email protected]>
Co-authored-by: Thibault Richard <[email protected]>
Thanks, committed your suggestions. Please merge when ready, I don't have access. |
Fixes #5262
To adjust recipes to the change in kibana (removing default policies), added system, elastic_agent, fleet_server packages to the preconfigured policies for ECK.