Support trial licenses inside enterprise_trial orchestration licenses #5097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
enterprise_trial
orchestration licenses can only contain short-livedenterprise
orplatinum
licenses (which one is applied depends on the version of Elasticsearch). This is confusing to users which expect a trial to be running if they apply a trial license. This PR prepares the ground to remedy this confusion by consistently using trial license across both the orchestrator and the Elastic stack.I have adjusted the existing e2e test to cover both cases, which means we no longer test the "I can apply the same enterprise_trial multiple times (as long as it's valid)". But I would argue that this is only about being able to apply a regular
enterprise
license to Elasticsearch which we are already covering in another test. So instead we now testing once the old-styleenterprise_trial
with short-livedenterprise
andplatinum
stack licenses and once the new-styleenterprise_trial
with a stacktrial
license inside.