Wait for E2E Job Pod log stream to be over before finishing E2E tests #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there are cases (eg. OCP) where streaming the E2E Pod logs is slower than others. In such case, we may end up in a situation where, at the end of the E2E tests, we haven't retrieved the full go test log. Which then makes the job fail in CI since test logs cannot be parsed and transformed to XML. This commit solves it by waiting for the streamStatus chan to report something (either err or nil), before returning from the `monitorTestJob` function.
anyasabo
approved these changes
Jul 1, 2020
david-kow
pushed a commit
to david-kow/cloud-on-k8s
that referenced
this pull request
Jul 17, 2020
…elastic#3377) I think there are cases (eg. OCP) where streaming the E2E Pod logs is slower than others. In such case, we may end up in a situation where, at the end of the E2E tests, we haven't retrieved the full go test log. Which then makes the job fail in CI since test logs cannot be parsed and transformed to XML. This commit solves it by waiting for the streamStatus chan to report something (either err or nil), before returning from the `monitorTestJob` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there are cases (eg. OCP) where streaming the E2E Pod logs is
slower than others. In such case, we may end up in a situation where, at
the end of the E2E tests, we haven't retrieved the full go test log, but still
end the test runner.
Which then makes the job fail in CI since test logs cannot be parsed and
transformed to XML.
This commit solves it by waiting for the streamStatus chan to report
something (either err or nil), before returning from the
monitorTestJobfunction.Relates #3130.