[Auditbeat] Sort IPv4 addresses before IPv6 #9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwurm
added
review
needs_backport
|
Pinging @elastic/secops |
webmat
approved these changes
Jan 8, 2019
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Jan 10, 2019
Changes the `host` dataset to sort IPv4 addresses of a network interface before IPv6 addresses. This matters because the first IP address of the first non-loopback interface will be used in the `message` string, and the IPv4 address (if it exists) should be easier to read and the more "expected" one for the user. (cherry picked from commit 204264a)
cwurm
added
v6.7.0
and removed
needs_backport
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Jan 10, 2019
Changes the `host` dataset to sort IPv4 addresses of a network interface before IPv6 addresses. This matters because the first IP address of the first non-loopback interface will be used in the `message` string, and the IPv4 address (if it exists) should be easier to read and the more "expected" one for the user. (cherry picked from commit 204264a)
cwurm
pushed a commit
that referenced
this pull request
Jan 10, 2019
) Changes the `host` dataset to sort IPv4 addresses of a network interface before IPv6 addresses. This matters because the first IP address of the first non-loopback interface will be used in the `message` string, and the IPv4 address (if it exists) should be easier to read and the more "expected" one for the user. (cherry picked from commit 204264a)
cwurm
pushed a commit
that referenced
this pull request
Jan 11, 2019
) Changes the `host` dataset to sort IPv4 addresses of a network interface before IPv6 addresses. This matters because the first IP address of the first non-loopback interface will be used in the `message` string, and the IPv4 address (if it exists) should be easier to read and the more "expected" one for the user. (cherry picked from commit 204264a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…) (elastic#9991) Changes the `host` dataset to sort IPv4 addresses of a network interface before IPv6 addresses. This matters because the first IP address of the first non-loopback interface will be used in the `message` string, and the IPv4 address (if it exists) should be easier to read and the more "expected" one for the user. (cherry picked from commit 7eac35b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, IP addresses collected from a network interfaces have no specific order. What can happen is that even though an interface has both IPv4 and IPv6 addresses, the IPv6 address might be returned first. This matters because the first IP address of the first non-loopback interface will be used in the
messagestring, e.g.:"message": "Host vagrant-2016 (IP: 10.0.2.15) restarted". The IPv4 address (if it exists) should be easier to read and the more "expected" one for the user.