Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Enable system module docs #9670

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Dec 19, 2018

With elastic/docs#512 merged we can enable links to x-pack/auditbeat/docs to have the system module included in the documentation.

@cwurm cwurm added review needs_backport PR is waiting to be backported to other branches. Auditbeat SecOps labels Dec 19, 2018
@cwurm cwurm requested a review from a team as a code owner December 19, 2018 13:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're missing the corresponding generated files, I think you need to run make docs?

# This is a very crude way of excluding references to X-Pack docs from
# the build until the docs build is updated with the new folder.
# TODO: Remove at the earliest possible time.
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did remove it at the earliest possible time! 💯

@cwurm
Copy link
Contributor Author

cwurm commented Dec 19, 2018

Seems like you're missing the corresponding generated files, I think you need to run make docs?

Ah, you're right. Added them.

@cwurm cwurm merged commit 8e2cc6c into elastic:master Dec 19, 2018
cwurm pushed a commit to cwurm/beats that referenced this pull request Dec 20, 2018
Enable Auditbeat system module docs.

(cherry picked from commit 8e2cc6c)
@cwurm cwurm added v6.7.0 v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. v6.7.0 labels Dec 20, 2018
cwurm pushed a commit to cwurm/beats that referenced this pull request Dec 20, 2018
Enable Auditbeat system module docs.

(cherry picked from commit 8e2cc6c)
@cwurm cwurm deleted the enable_system_module_docs branch December 20, 2018 13:40
cwurm pushed a commit that referenced this pull request Dec 20, 2018
Cherry-pick of PR #9670 to 6.x branch. Original message: 

With elastic/docs#512 merged we can enable links to `x-pack/auditbeat/docs` to have the system module included in the documentation.
cwurm pushed a commit that referenced this pull request Dec 20, 2018
Cherry-pick of PR #9670 to 6.6 branch. Original message: 

With elastic/docs#512 merged we can enable links to `x-pack/auditbeat/docs` to have the system module included in the documentation.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
elastic#9717)

Cherry-pick of PR elastic#9670 to 6.6 branch. Original message: 

With elastic/docs#512 merged we can enable links to `x-pack/auditbeat/docs` to have the system module included in the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants