Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve broken download link #9636

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Resolve broken download link #9636

merged 1 commit into from
Jan 24, 2019

Conversation

cachedout
Copy link
Contributor

I don't know enough about how and where packages are supposed to be deployed that I can be completely confident this is correct, so please double-check. :)

@dedemorton or @jsoriano may be able to verify, perhaps.

Closes #9580

@cachedout cachedout requested a review from a team as a code owner December 18, 2018 19:53
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@webmat
Copy link
Contributor

webmat commented Dec 18, 2018

jenkins, test this please

@dedemorton
Copy link
Contributor

So it looks like the download link changed for 6.5.3 (or maybe 6.5.2), so this path needs to be changed in the 6.5 branch. However, if you merge this into master, you will break the download for Alpha 1 (the path cannot be changed until Apha 2 is released, when I assume we will be using the changed path).

@ph Should we be changing download paths on bug fix releases? Not sure, but won't this affect customers who are using automation? (I dunno...just speculating.)

@acchen97 I'm on vacation the next couple of weeks (checking email sporadically). Can you make sure this gets resolved? I expect the path change will be relevant in master when we release alpha2. So what needs to happen is that someone needs to cherry-pick and merge this into 6.5, then when Alpha 2 releases, someone needs to merge this PR into master. I hope this makes sense.

@dedemorton
Copy link
Contributor

So it looks like the download link changed for 6.5.3 (or maybe 6.5.2), so this path needs to be changed in the 6.5 branch. However, if you change it in master you will break the download for Alpha 1 (the path cannot be changed until Apha 2 is released).

@ph Should we be changing download paths on bug fix releases? Not sure, but doesn't this affect customers who have automation in place?

@acchen97 I'm on vacation the next couple of weeks (just checking email sporadically). Can you make sure this gets resolved?

@dedemorton dedemorton mentioned this pull request Dec 19, 2018
Closed
@ph ph added the docs label Dec 19, 2018
@ph
Copy link
Contributor

ph commented Dec 19, 2018

@dedemorton @acchen97 I think the course of action here is to merge this change everywhere because this is the new path. Concerning automation, the beat is in beta and I don't think automation is used that much in that context, since functionbeat cli is somewhat an automation.

@PosicubeBeege
Copy link

This is still an issue

@dedemorton
Copy link
Contributor

jenkins test this please

@dedemorton
Copy link
Contributor

@ PosicubeBeege Thanks for bringing this to my attention. I will make sure this change gets merged asap.

dedemorton
dedemorton approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor

The build errors are not related to docs, so I am merging this.

@dedemorton dedemorton merged commit bb351d7 into elastic:master Jan 24, 2019
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jan 24, 2019
@cachedout @dedemorton
Resolve broken download link (elastic#9636)
2c010a2 
Closes elastic#9580

(cherry picked from commit bb351d7)
@dedemorton dedemorton mentioned this pull request Jan 24, 2019
Merged
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jan 24, 2019
@cachedout @dedemorton
Resolve broken download link (elastic#9636)
f68c439 
Closes elastic#9580

(cherry picked from commit bb351d7)
@dedemorton dedemorton mentioned this pull request Jan 24, 2019
Merged
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jan 24, 2019
@cachedout @dedemorton
Resolve broken download link (elastic#9636)
e8f81be 
Closes elastic#9580

(cherry picked from commit bb351d7)
@dedemorton dedemorton mentioned this pull request Jan 24, 2019
Merged
ph pushed a commit that referenced this pull request Jan 25, 2019
@dedemorton @ph
Backport to 6.5: Resolve broken download link (#9636) (#10327)
380f748 
Cherry-picks #9636 into 6.5 branch.

(cherry picked from commit bb351d7)
ph pushed a commit that referenced this pull request Jan 25, 2019
@dedemorton @ph
Backport to 6.6: Resolve broken download link (#9636) (#10328)
dc69624 
Cherry-picks #9636 into the 6.6 branch.

(cherry picked from commit bb351d7)
ph pushed a commit that referenced this pull request Jan 25, 2019
@dedemorton @ph
Backport to 6.x: Resolve broken download link (#9636) (#10329)
881284c 
Cherry-picks #9636 into the 6.x branch.

(cherry picked from commit bb351d7)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton @ph
Backport to 6.6: Resolve broken download link (elastic#9636) (elastic…
63494f1 
…#10328)

Cherry-picks elastic#9636 into the 6.6 branch.

(cherry picked from commit 5b20b44)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton @ph
Backport to 6.5: Resolve broken download link (elastic#9636) (elastic…
d36d4a1 
…#10327)

Cherry-picks elastic#9636 into 6.5 branch.

(cherry picked from commit 5b20b44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedemorton dedemorton dedemorton approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cachedout @elasticmachine @webmat @dedemorton @ph @PosicubeBeege