[WIP] ILM with configuration per index #9616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable ILM for all indices that have a `rollover_policy` defined, and a valid index name. Add more default rollover policies.
houndci-bot
reviewed
Dec 18, 2018
| return nil | ||
| } | ||
|
|
||
| func (l *Loader) LoadWriteAlias() error { |
There was a problem hiding this comment.
exported method Loader.LoadWriteAlias should have comment or be unexported
| }, nil | ||
| } | ||
|
|
||
| func (l *Loader) LoadPolicies() error { |
There was a problem hiding this comment.
exported method Loader.LoadPolicies should have comment or be unexported
| GetVersion() common.Version | ||
| } | ||
|
|
||
| type Loader struct { |
There was a problem hiding this comment.
exported type Loader should have comment or be unexported
| "github.com/elastic/beats/libbeat/template" | ||
| ) | ||
|
|
||
| type ESClient interface { |
There was a problem hiding this comment.
exported type ESClient should have comment or be unexported
5 tasks
|
Closing this in favour of #10002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to:
rollover_policydefined. Add more default policies so they are also usable for APM. ILM changes have been discussed with @ruflin upfront.TODO: add more tests
cc @elastic/apm-server
Example config
metricbeat:Example config
apm: