Increase script.max_compilations_rate to get tests passing #9613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
review
Filebeat
This is a temporary fix for elastic#9587. The reason I did not skip the tests instead was that I would still like us to have tests for the pipelines running until we figured out which script is the culprit.
ruflin
force-pushed
the
test_input_pipeline_config-skip
branch
from
50dd2f5 to
5e87224
Compare
|
Can this happen when testing modules too? or this only happens on |
|
@jsoriano I would assume it could happen on modules testing too. The difference there is that the tests are further apart and take longer. My focus of this PR is only a temporary fix to get the builds back to green. |
jsoriano
approved these changes
Dec 18, 2018
|
This PR does not fix the actual issue. Work needs to be done to investigate where the problem actually comes from and fix it. |
|
@jsoriano Yeah it happened to me while working on Filebeat modules |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #9587. The reason I did not skip the tests instead was that I would still like us to have tests for the pipelines running until we figured out which script is the culprit.