Update description added by processor #9429
Conversation
dedemorton
added
docs
review
needs_backport
There was a problem hiding this comment.
I think we can find ways to make it unique, see comment. If it's not the easy, lets focus on the big cleanup step and figure out what the end result is we would want to have.
@dedemorton I suggest you come up with a proposal and then we figure out how we can automate this. Now with ECS and the same fields coming from many different places, I wonder if for docker fields we even need different titles?
| @@ -1,7 +1,7 @@ | |||
| - key: docker | |||
There was a problem hiding this comment.
I would assume if we change this from - key: docker to key: docker-processor it could be that we will end up with 2 titles.
There was a problem hiding this comment.
The title field needed to be changed. I tried that before, but I made the change in the yml for the module rather than the processor, and it affected messages as well as the topic title. But you're right...it works if you change the title in the processor instead. I think this is a good enough fix for now, but we'll come up with a better approach later that's more consistent.
|
@ruflin This should be ready for review. It's a quick fix, but I get your point about the titles. I'll work with Karen to come up with the best structure to use for displaying the info, then we can decide how to implement it. |
|
I had to restart Jenkins to perform upgrades and this job was cancelled...kicking it off again. Jenkins, test this please. |
|
I'm closing this because we need to find a more consistent way of indicating how the data in these fields are collected. To continue the discussion see #9519 |
dedemorton
removed
the
needs_backport
Closes #9272.
Note that we use scripts to generate this content. Therefore, it's not possible (at the moment) to have different headings.I have updated the description to show that the fields are added by theadd_docker_metadataprocessor.@ruflin Can you think of a way to make the titles unique? I tried updating the title in fields.yml, but it changed message text, and I don't think we want to do that. As part of our effort to clean up the formatting, let's find a way to make the titles more unique. BTW, how is the asset string is used? Is it supposed to get updated?