Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add freebsd support for the uptime metricset #9413

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Add freebsd support for the uptime metricset #9413

merged 2 commits into from
Dec 13, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Dec 6, 2018 •
edited
Loading

@jsoriano jsoriano added enhancement module review Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Dec 6, 2018
@jsoriano jsoriano self-assigned this Dec 6, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/infrastructure

@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Dec 6, 2018
ruflin
ruflin approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait until at least one of the other 2 reviewed it too.

@ruflin
Copy link
Contributor

ruflin commented Dec 13, 2018

@jsoriano You can ignore the Travis failure on this one as it should be fixed in master.

@jsoriano
Copy link
Member Author

@andrewkroh @kaiyan-sheng could any of you also review this? thanks!

sayden
sayden approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewkroh
andrewkroh approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit 26cef51 into elastic:master Dec 13, 2018
@jsoriano jsoriano deleted the uptime-freebsd branch December 13, 2018 16:04
@jsoriano jsoriano mentioned this pull request Dec 13, 2018
Merged
@jsoriano jsoriano added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 13, 2018
jsoriano added a commit to jsoriano/beats that referenced this pull request Dec 13, 2018
@jsoriano
Add freebsd support for the uptime metricset (elastic#9413)
f94524a 
(cherry picked from commit 26cef51)
jsoriano added a commit that referenced this pull request Dec 14, 2018
@jsoriano
Add freebsd support for the uptime metricset (#9413) (#9529)
6f8366d 
(cherry picked from commit 26cef51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@sayden sayden sayden approved these changes

@ruflin ruflin ruflin approved these changes

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

Assignees

@jsoriano jsoriano

Labels
enhancement Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoriano @elasticmachine @ruflin @sayden @andrewkroh