Central management for hb #9254
Conversation
andrewvc
added
in progress
andrewvc
force-pushed
the
central-mngmnt
branch
from
1558941 to
bcbf5a5
Compare
andrewvc
added
review
needs_backport
andrewvc
force-pushed
the
central-mngmnt
branch
from
bcbf5a5 to
2e1f4de
Compare
This patch adds support for CM features and documents them as well.
andrewvc
force-pushed
the
central-mngmnt
branch
from
2e1f4de to
556f986
Compare
| @@ -82,6 +84,10 @@ func (bt *Heartbeat) Run(b *beat.Beat) error { | |||
| return err | |||
| } | |||
|
|
|||
| if b.ConfigManager.Enabled() { | |||
| bt.RunCentralMgmtMonitors(b) | |||
There was a problem hiding this comment.
Why not registering these always? I'm wondering if there could be a timing issue here, something like:
- Central Management fetches configs and calls reload,
heartbeat.monitorsis not yet registered - This code registers the reloadable after that
There was a problem hiding this comment.
Hmmm, I just copied from https://github.com/elastic/beats/blob/master/metricbeat/beater/metricbeat.go#L109 but if it isn't necessary I'm glad to remove the conditional.
Is that safe?
There was a problem hiding this comment.
I checked how it's done in Metricbeat and it could have the same issue, I'm guessing that even in the improbable case of this happening, it would be fixed by the next pass on config apply. 👍 to leave it like this
|
@exekias @ruflin I've added another commit that removes the CM docs from this patch. Thinking about it, Heartbeat will be administered from a dedicated Uptime UI, not CM, so those docs don't apply. Documenting this is premature. For now, I believe, we should leave the UI experience undocumented till we're further along. Perhaps we should only merge this into master now until we have a story there. |
ruflin
added
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
andrewvc
removed
the
needs_backport
Adds central management to heartbeat. Works together with elastic/kibana#26219