Log dropped events at the debug level #9251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
log-failed-events
branch
from
0c2e669 to
9748535
Compare
urso
suggested changes
Nov 27, 2018
| return func(event interface{}) (d []byte, err error) { | ||
| d, err = enc.Encode(index, event.(*beat.Event)) | ||
| if err != nil { | ||
| debugf("Failed to encode event: %v", event) |
There was a problem hiding this comment.
We should still include an error log here, as we have for the other outputs. Otherwise it's most likely to get unnoticed.
There was a problem hiding this comment.
There are already errors logged for all events failures for both implementations (sync and async). But I wanted to add debug logging only for events failed to encode, and unlike the other outputs, on this one it is not easy to differentiate if it was an encoding event at the point where the general message is logged. This is why I add this debug message here.
jsoriano
added
the
needs_backport
urso
approved these changes
Nov 30, 2018
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 2, 2018
Log events dropped by encoding problems at the debug level. (cherry picked from commit 1180b37)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 2, 2018
Log events dropped by encoding problems at the debug level. (cherry picked from commit 1180b37)
jsoriano
added a commit
that referenced
this pull request
Dec 6, 2018
jsoriano
added a commit
that referenced
this pull request
Dec 6, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Log events dropped by encoding problems at the debug level. (cherry picked from commit 23a6050)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log dropped events to help on cases related to #9212