-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to disable docker cpu metrics collection per core #9194
Merged
jsoriano
merged 3 commits into
elastic:master
from
jsoriano:docker-disable-cpu-per-core
Nov 23, 2018
Merged
Add flag to disable docker cpu metrics collection per core #9194
jsoriano
merged 3 commits into
elastic:master
from
jsoriano:docker-disable-cpu-per-core
Nov 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
review
Metricbeat
Metricbeat
needs_backport
PR is waiting to be backported to other branches.
containers
Related to containers use case
labels
Nov 21, 2018
houndci-bot
reviewed
Nov 21, 2018
jsoriano
force-pushed
the
docker-disable-cpu-per-core
branch
from
November 21, 2018 09:52
e202747
to
c7f8800
Compare
ruflin
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jsoriano I resolved the changelog conflict. |
This was referenced Nov 23, 2018
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Nov 23, 2018
Issues added for flaky tests |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Nov 23, 2018
) (cherry picked from commit 52df22d)
jsoriano
added
v6.6.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Nov 23, 2018
jsoriano
added a commit
that referenced
this pull request
Nov 23, 2018
This was referenced Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker CPU metrics collection per core can create loads of fields in hosts with lots of CPUs, and I am not sure if this is so useful. Add a flag to be able disable them by now on 6.6, and we can consider later to disable them by default on 7.0.