Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for loading journalbeat dashboards #9167

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Nov 20, 2018

I haven't added the dashboard image yet (currently commented out) because I couldn't get the dashboard to load properly even though Journalbeat is sending data to Elasticsearch.

image

@dedemorton dedemorton added docs in progress Pull request is currently in progress. review needs_backport PR is waiting to be backported to other branches. labels Nov 20, 2018
@dedemorton dedemorton requested review from urso and kvch November 20, 2018 05:12
@@ -29,26 +29,28 @@ data path. See the <<directory-layout>> section for details. The default is `${p
----

[float]
==== `backoff`
==== `backoff` deprecated[5.6.1,Use the option under `paths` instead.]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to use an inline deprecation rather than putting this on a separate line because it looks better (otherwise, the inline text is a very large font...too distracting to a minor deprecation like this).

@kvch
Copy link
Contributor

kvch commented Nov 20, 2018

I am looking into the dashboard problem.

@kvch
Copy link
Contributor

kvch commented Nov 20, 2018

To me it seems like the dashboard is broken. What do you think about not documenting the dashboard now and releasing a proper one in 6.6?

@dedemorton
Copy link
Contributor Author

Sounds good!

@kvch
Copy link
Contributor

kvch commented Nov 21, 2018

Opened an issue for the dashboard problem: #9195

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor Author

@kvch I've loaded the journalbeat dashboards from 6.6.0 BC2 and still see this issue. Can you confirm that the dashboard should work in 6.6?

@kvch
Copy link
Contributor

kvch commented Jan 11, 2019

Yes. Let me try again with the dashboard. If it's not working, we should not add docs for the dashboard in 6.6.

@dedemorton
Copy link
Contributor Author

@kvch I downloaded 6.6.0 GA today, and I'm still seeing problems with the Journalbeat dashboard:

image

Can you confirm? Will this be fixed for the next release?

@kvch
Copy link
Contributor

kvch commented Feb 4, 2019

I have added a new dashboard to Journalbeat: #10517
Do you mind testing it?

@dedemorton dedemorton removed the v6.5.2 label Feb 5, 2019
@dedemorton dedemorton force-pushed the add_journalbeat_dashbaords branch from 18e8e0d to 60b03dc Compare February 5, 2019 21:10
@dedemorton dedemorton requested a review from a team as a code owner February 5, 2019 21:10
@dedemorton dedemorton added v6.7.0 and removed in progress Pull request is currently in progress. labels Feb 5, 2019
@dedemorton
Copy link
Contributor Author

@kvch I tested the dashboard in the latest 6.7.0 snapshot, and it works! This PR should be ready to merge assuming it passes CI. Do you want to take one last look?

@dedemorton dedemorton merged commit 2fe5aab into elastic:master Feb 15, 2019
@dedemorton dedemorton deleted the add_journalbeat_dashbaords branch February 15, 2019 20:31
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 6, 2019
* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 6, 2019
* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Mar 6, 2019
dedemorton added a commit that referenced this pull request Mar 20, 2019
…0833 #10859)  (#11120)

* Add steps for loading journalbeat dashboards  (#9167)

* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc

* Fix log path format in logging example (#10647)

* Add systemd compatibility statement (#10740)

* Remove simplistic docker command examples (#10741)

* Fix attribute references (#10742)

* Remove broken link to docker source code (#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (#10859)
dedemorton added a commit that referenced this pull request Mar 21, 2019
…0833 #10859) (#11119)

* Add steps for loading journalbeat dashboards  (#9167)

* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc

* Fix log path format in logging example (#10647)

* Add systemd compatibility statement (#10740)

* Remove simplistic docker command examples (#10741)

* Fix attribute references (#10742)

* Remove broken link to docker source code (#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (#10859)
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
…0740 elastic#10741 elastic#10742 elastic#10833 elastic#10859) (elastic#11119)

* Add steps for loading journalbeat dashboards  (elastic#9167)

* Add steps for loading and viewing dashboards

* Deprecate global options for backoff, max_backoff, seek, and include_matches

* Add screen capture

* Move tip to correct place in doc

* Fix log path format in logging example (elastic#10647)

* Add systemd compatibility statement (elastic#10740)

* Remove simplistic docker command examples (elastic#10741)

* Fix attribute references (elastic#10742)

* Remove broken link to docker source code (elastic#10833)

* Remove link to old repo for docker source

* Remove dockergithub attribute

* Add links to Logstash docs about working with Filebeat modules (elastic#10859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants