Add x-pack badge to functionbeat topics #9082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
the
needs_backport
ph
approved these changes
Nov 14, 2018
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Nov 15, 2018
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Nov 15, 2018
dedemorton
removed
the
needs_backport
dedemorton
added a commit
that referenced
this pull request
Nov 15, 2018
dedemorton
added a commit
that referenced
this pull request
Nov 15, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The x-pack "badge" created by the xpack role is the only way we have right now of flagging content about features that require a license.
The best I can do for now is to add x-pack labels to most of the sections. I can use some conditional coding to add the x-pack role to topics that come from the shared files in libbeat, but I wonder if it's worth the effort. We need a better way to flag the whole book.