Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keystore's flaky tests #9062

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Fix keystore's flaky tests #9062

merged 4 commits into from
Nov 15, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 13, 2018

We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times

@urso
Copy link

urso commented Nov 13, 2018

Did restart travis. libbeat tests didn't run due to docker flakyness :)

@ph
Copy link
Contributor Author

ph commented Nov 13, 2018 •
edited
Loading

@urso I will explicitly check for dir to make sure the key is correct, I had second thoughts from @jsoriano comment.

@jsoriano jsoriano mentioned this pull request Nov 14, 2018
Merged
@ruflin
Copy link
Contributor

ruflin commented Nov 14, 2018

jenkins, test it

@ruflin
Copy link
Contributor

ruflin commented Nov 14, 2018

Failing test should be fixed in master (couchbase). Could you rebase on top of master to see if it goes green?

ph added 4 commits November 14, 2018 19:55
@ph
Fix keystore's flaky tests
0054dee 
We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

```
test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times
```
@ph
Assert the directory name is coming from the keystore.
bb47da6
@ph
join
b533be6
@ph
pep8
0874c80
@ph ph force-pushed the fix/keystore-test-suite branch from 4a55a95 to 0874c80 Compare November 15, 2018 00:55
@ph
Copy link
Contributor Author

ph commented Nov 15, 2018

rebased lets see how it goes

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Nov 15, 2018
@ph ph merged commit 2f9f021 into elastic:master Nov 15, 2018
ph added a commit to ph/beats that referenced this pull request Nov 15, 2018
@ph
Fix keystore's flaky tests (elastic#9062)
943e4ea 
We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

```
test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times
```

(cherry picked from commit 2f9f021)
@ph ph mentioned this pull request Nov 15, 2018
Merged
@ph ph added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 15, 2018
ph added a commit to ph/beats that referenced this pull request Nov 15, 2018
@ph
Fix keystore's flaky tests (elastic#9062)
ecdca4b 
We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

```
test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times
```

(cherry picked from commit 2f9f021)
@ph ph mentioned this pull request Nov 15, 2018
Merged
@ph ph added the v6.5.1 label Nov 15, 2018
@jsoriano jsoriano mentioned this pull request Nov 23, 2018
Merged
ph added a commit that referenced this pull request Nov 23, 2018
@ph
Fix keystore's flaky tests (#9062) (#9100)
7637a31 
We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

```
test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times
```

(cherry picked from commit 2f9f021)
ph added a commit that referenced this pull request Nov 23, 2018
@ph
Cherry-pick #9062 to 6.x: Fix keystore's flaky tests (#9098)
fa0fd65 
Cherry-pick of PR #9062 to 6.x branch. Original message: 

We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

```
test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times
```
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ph
Fix keystore's flaky tests (elastic#9062) (elastic#9100)
fcaf059 
We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.

Fix the following:

```
test_keystore_with_present_key	failed 3 times:
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 2 times
 	elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx	failed 1 times
test_keystore_with_nested_key	failed 2 times:
 	elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows	failed 1 times
 	elastic+beats+master+multijob-windows/beat=libbeat,label=windows	failed 1 times
```

(cherry picked from commit 61133ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@ruflin ruflin ruflin approved these changes

@urso urso urso approved these changes

Assignees
No one assigned
Labels
libbeat review :Testing v6.5.1 v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ph @urso @ruflin @jsoriano