-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for dashboards under 7.0 #9031
Conversation
20050b7
to
f1cf5cf
Compare
@tsg I tested this locally a bit and it seems to fix most dashboard issues. There is still something odd when I go to "System Host View" directly which I think is related to |
This PR initially broke our tests. The reasons is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I approve of this.
As some of libbeat fields were renamed in 7.0, currently a few dashboards break that depend on this fields. Adding an alias for the old fields is to temporarly fix this. As soon as the ECS migration is done, fields in the dashboard have to be renamed. Hopefully this can happen in an automated way.
9f42b56
to
d060be2
Compare
@tsg I had to rebase again because of a conflict and want to make sure builds still go green. So if I don't get to merge it today, could you merge for me? |
As some of libbeat fields were renamed in 7.0, currently a few dashboards break that depend on this fields. Adding an alias for the old fields is to temporarly fix this. As soon as the ECS migration is done, fields in the dashboard have to be renamed. Hopefully this can happen in an automated way.
As some of libbeat fields were renamed in 7.0, currently a few dashboards break that depend on this fields. Adding an alias for the old fields is to temporarly fix this. As soon as the ECS migration is done, fields in the dashboard have to be renamed. Hopefully this can happen in an automated way.