-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging trace at debug level for the pipeline client. #9016
Merged
ph
merged 6 commits into
elastic:master
from
ph:fix/adding-more-logging-for-client-pipeline
Dec 11, 2018
Merged
Add logging trace at debug level for the pipeline client. #9016
ph
merged 6 commits into
elastic:master
from
ph:fix/adding-more-logging-for-client-pipeline
Dec 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
added
in progress
Pull request is currently in progress.
libbeat
needs_backport
PR is waiting to be backported to other branches.
labels
Nov 9, 2018
urso
reviewed
Nov 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on the changes. But a little more human readable texts would be nice.
To allow easier debugging when events are not sent by the output we have added a few log statements at debug level for the onFilteredOut and the onDroppedOnPublish events.
ph
force-pushed
the
fix/adding-more-logging-for-client-pipeline
branch
from
December 6, 2018 20:23
f4490e3
to
6da11e9
Compare
I've updated the log message, I wanted to keep the same style as the other log in the file. |
Backport for 6.x 6.5 |
urso
approved these changes
Dec 10, 2018
ph
added a commit
to ph/beats
that referenced
this pull request
Feb 4, 2019
* Add logging trace at debug level for the pipeline client. To allow easier debugging when events are not sent by the output we have added a few log statements at debug level for the onFilteredOut and the onDroppedOnPublish events. (cherry picked from commit 465b1a2)
ph
added
v6.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 4, 2019
ph
added a commit
that referenced
this pull request
Feb 5, 2019
…peline client. (#10529) * Add logging trace at debug level for the pipeline client. (#9016) * Add logging trace at debug level for the pipeline client. To allow easier debugging when events are not sent by the output we have added a few log statements at debug level for the onFilteredOut and the onDroppedOnPublish events. (cherry picked from commit 465b1a2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow easier debugging when events are not sent by the output we
have added a few log statements at debug level for the onFilteredOut and
the onDroppedOnPublish events.