Cherry-pick #8667 to 6.x: JSON Checks for Heartbeat HTTP Monitors #9015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `json` check for HTTP responses letting users define an arbitrary condition to match against parsed JSON to determine whether an endpoint is up or down. The nice thing about structured checks like this is that it makes it easy for users to precisely piggy-back on top of existing JSON endpoints, or write their own where a given key/value could indicate the health of an external system. In a sense, it allows users to write a healthcheck endpoint. An example can be seen below: ```yaml heartbeat.monitors: - type: http # List or urls to query urls: ["http://localhost:9200"] schedule: '@every 10s' check.response.json: - description: check version condition: equals.version.number: "6.4.0" ``` (cherry picked from commit 22ba375)
ruflin
approved these changes
Nov 11, 2018
| @@ -24,7 +24,12 @@ import ( | |||
| "net/http/httptest" | |||
| "testing" | |||
|
|
|||
| "github.com/elastic/beats/libbeat/common" | |||
There was a problem hiding this comment.
Was probably also in original PR so ...
There was a problem hiding this comment.
Gah. Will open a follow-up to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8667 to 6.x branch. Original message:
Note: This is rebased on top of #8660 since that bug breaks the integration tests here
Add JSON body check support to Heartbeat
This commit adds a new
jsoncheck for HTTP responses letting users define an arbitrary condition to match against parsed JSON to determine whether an endpoint is up or down.The nice thing about structured checks like this is that it makes it easy for users to precisely piggy-back on top of existing JSON endpoints, or write their own where a given key/value could indicate the health of an external system. In a sense, it allows users to write a healthcheck endpoint.
An example can be seen below:
Fixes #7936