Fix export_dashboards command #8954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`panelJSON` is/can be an array, so marshaling to MapStr caused problems. I think this was the root cause for elastic#8952.
tsg
added
needs_backport
andrewkroh
approved these changes
Nov 7, 2018
| @@ -117,7 +117,7 @@ func decodeValue(data common.MapStr, key string) { | |||
| return | |||
| } | |||
| s := v.(string) | |||
| var d common.MapStr | |||
| var d interface{} | |||
| json.Unmarshal([]byte(s), &d) | |||
There was a problem hiding this comment.
This code is lax on error handling. Checking the Unmarshal result and returning an error or panicking would be helpful.
|
@joshuar @ycombinator Haven't tested it but it might also fix #8200 |
|
@andrewkroh @tsg Here is the commit for #7730 for the error handling 9ff0847 |
ycombinator
added
v6.6.0
and removed
needs_backport
ycombinator
added a commit
that referenced
this pull request
Nov 19, 2018
bobapple
added a commit
to Icinga/icingabeat
that referenced
this pull request
Dec 20, 2018
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jan 4, 2019
This dashboard was probably exported prior to the fix for elastic#8954. Fixes elastic#9850
andrewkroh
added a commit
that referenced
this pull request
Jan 5, 2019
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jan 6, 2019
This dashboard was probably exported prior to the fix for elastic#8954. Fixes elastic#9850 (cherry picked from commit eddf69e)
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jan 6, 2019
This dashboard was probably exported prior to the fix for elastic#8954. Fixes elastic#9850 (cherry picked from commit eddf69e)
andrewkroh
added a commit
that referenced
this pull request
Jan 8, 2019
andrewkroh
added a commit
that referenced
this pull request
Jan 10, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This dashboard was probably exported prior to the fix for elastic#8954. Fixes elastic#9850 (cherry picked from commit cbbb7dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panelJSONis/can be an array, so marshaling to MapStr causedproblems. I think this was the root cause for #8952.