Index cluster_uuid in elasticsearch/node metricset #8771
Conversation
ycombinator
added
review
Metricbeat
|
There still seems to be some troubles with CI |
|
@ruflin I addressed the CI troubles. Ready for your review again. Thanks! |
| @@ -48,7 +48,6 @@ func TestFetch(t *testing.T) { | |||
| w.WriteHeader(200) | |||
| w.Header().Set("Content-Type", "application/json;") | |||
| w.Write([]byte(response)) | |||
| assert.Equal(t, "/_nodes/_local", r.RequestURI) | |||
There was a problem hiding this comment.
Is this not correct anymore?
There was a problem hiding this comment.
It's correct but I removed it because none of the other tests that spin up a HTTP server like this have an assertion in them. Also, for some bizzare reason this test works locally, but only fails in CI.
There was a problem hiding this comment.
That it works locally and fails on CI makes me worry now because I think it passed previously.
There was a problem hiding this comment.
Alright, digging into it some more...
There was a problem hiding this comment.
My bad, I must've been mixing up PRs last night. This test clearly failed locally as well just now (several times) and the issue was obvious. Fixed it in 34310c1.
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
None of the other test HTTP servers used in the Metricbeat codebase use an assertion like this so I thought it was safe to get rid of this one.
|
@ruflin All the things are green now on this PR and review feedback has been addressed. Please take another gander whenever you get a chance. Thanks! [EDIT] As mentioned in another PR comment, I'll add an overall CHANGELOG entry for all these fields in various ES metricsets in the final PR (yet to be put up). |
ycombinator
removed
the
needs_backport
This PR teaches the
elasticsearch/nodemetricset to index the Elasticsearchcluster_uuidas the module-levelcluster.idfield.