Cherry-pick #8228 to 6.x: Additional Heartbeat Reload Tests #8548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a mocked test of the Monitor type * Minimizes the required mockable area by introducing a PipelineConnector type that is easier to mock than a Pipeline. * Introduces a number of useful mocks for future tests potentially. (cherry picked from commit 0417f98)
exekias
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8228 to 6.x branch. Original message:
This PR attempts to improve the testing and testability of heartbeat in the following ways:
MonitortypePipelineConnectortype that is easier to mock than aPipeline.