Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 6.x: Multiple doc changes (#7696 #7883 #7888 #7889 #7903 #7937 #7939 #7948 #7949 #7950) #8011

Closed
wants to merge 12 commits into from

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Aug 17, 2018

Closed and replaced by: #8188

Cherry-picks the following doc PRs into the 6.x branch. Note that running make update resulted in some updates I wasn't expecting. Need someone to confirm that they are good for 6.x. Don't seem related the changes in cherry-picked PRs.

#7696
#7883
#7888
#7889
#7903
#7937
#7939
#7948
#7949
#7950

@dedemorton dedemorton added docs in progress Pull request is currently in progress. review backport and removed in progress Pull request is currently in progress. labels Aug 17, 2018
@dedemorton dedemorton changed the title Backport to 6.x: Multiple doc chagnes (#7696 #7883 #7888 #7889 #7903 #7937 #7939 #7948 #7949 #7950 Backport to 6.x: Multiple doc chagnes (#7696 #7883 #7888 #7889 #7903 #7937 #7939 #7948 #7949 #7950) Aug 17, 2018
@dedemorton dedemorton changed the title Backport to 6.x: Multiple doc chagnes (#7696 #7883 #7888 #7889 #7903 #7937 #7939 #7948 #7949 #7950) Backport to 6.x: Multiple doc changes (#7696 #7883 #7888 #7889 #7903 #7937 #7939 #7948 #7949 #7950) Aug 17, 2018
@jsoriano
Copy link
Member

It LGTM, make update will be needed though.

ruflin and others added 12 commits August 30, 2018 15:57
* Add document for beat export dashboard

Follow up from elastic#7239

* move to command reference

* address review comments

* review comments applied

* apply review feedback
* Add docs about append_fields
* Remove experimental tag from setup.template.json.enabled description
{ needs escaping as otherwise asciidoc will show an empty code block.
* Metricbeat: Add compatibility notes where missing, based on integration tests

* Added review suggestions
I've been told that using "golang" instead of "Go" is considered a faux pas in some circles. :-)

I've replaced instances in the external docs, but I did not update the changelog, readmes, or code files.
@dedemorton dedemorton force-pushed the cherrypick_docs_08.17.18_6.x branch from b7e1be4 to 47b711f Compare August 30, 2018 23:01
@dedemorton
Copy link
Contributor Author

@jsoriano I rebased and ran make update again. Can you take another look before I merge. Thanks!

@jsoriano
Copy link
Member

@dedemorton test builds still fail due to make update needed :(

@dedemorton
Copy link
Contributor Author

jenkins, test this

@dedemorton
Copy link
Contributor Author

When I run make update there are no files changed. I kicked off another build. If this one fails, maybe it'll be faster for me to close this and create a new PR with the cherry-picks.

@dedemorton
Copy link
Contributor Author

This PR is messed up, so I've created another PR with the cherrypicks here: #8188

@dedemorton dedemorton closed this Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants