Update go-txfile and dependencies #7859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can |
|
@andrewkroh yes, it should be unskipped. Thank you! |
urso
force-pushed
the
upd/go-txfile-0.0.2
branch
from
94fc470 to
4b4f2a1
Compare
urso
changed the title
added 12 commits
August 7, 2018 20:17
go-txfile requires a newer version of golang.org/x/sys
fix crossbuild
urso
force-pushed
the
upd/go-txfile-0.0.2
branch
from
8e0efee to
d5402d2
Compare
ph
approved these changes
Aug 8, 2018
| for len(b.pending) > 0 { | ||
| n, err := b.queue.Writer().Write(b.pending) | ||
| n, err := w.Write(b.pending) |
There was a problem hiding this comment.
This error will get hidden, should we log it as debug?
There was a problem hiding this comment.
It's not logged on purpose. There can be a many reasons why this fails. E.g. IO error vs. spool is full. The later one is no error, but expected behavior. In future PRs we will check for the causes + handle/log them appropriately.
| avail, err := reader.Available() | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
This error will be logged by the beat. The spool constructor fails if this call fails.
urso
added
v6.5.0
and removed
needs_backport
urso
pushed a commit
to urso/beats
that referenced
this pull request
Aug 8, 2018
* Update go-txfile * Update golang.org/x/sys go-txfile requires a newer version of golang.org/x/sys * Update spool to take API changes into account * Ensure spool opening root cause is included when printing the error message * cleanup vendor after govendor fails * Update notice file * Update changelog * Fix build * Update go-txfile to 0.0.3 (cherry picked from commit 10f41be)
urso
pushed a commit
to urso/beats
that referenced
this pull request
Aug 8, 2018
* Update go-txfile * Update golang.org/x/sys go-txfile requires a newer version of golang.org/x/sys * Update spool to take API changes into account * Ensure spool opening root cause is included when printing the error message * cleanup vendor after govendor fails * Update notice file * Update changelog * Fix build * Update go-txfile to 0.0.3 (cherry picked from commit 10f41be)
kvch
pushed a commit
that referenced
this pull request
Aug 8, 2018
* Update go-txfile * Update golang.org/x/sys go-txfile requires a newer version of golang.org/x/sys * Update spool to take API changes into account * Ensure spool opening root cause is included when printing the error message * cleanup vendor after govendor fails * Update notice file * Update changelog * Fix build * Update go-txfile to 0.0.3 (cherry picked from commit 10f41be)
kvch
pushed a commit
that referenced
this pull request
Aug 8, 2018
* Update go-txfile * Update golang.org/x/sys go-txfile requires a newer version of golang.org/x/sys * Update spool to take API changes into account * Ensure spool opening root cause is included when printing the error message * cleanup vendor after govendor fails * Update notice file * Update changelog * Fix build * Update go-txfile to 0.0.3 (cherry picked from commit 10f41be)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Update go-txfile * Update golang.org/x/sys go-txfile requires a newer version of golang.org/x/sys * Update spool to take API changes into account * Ensure spool opening root cause is included when printing the error message * cleanup vendor after govendor fails * Update notice file * Update changelog * Fix build * Update go-txfile to 0.0.3 (cherry picked from commit b6e44a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7849, #7867, #7720
This PR updates go-txfile to v0.0.3 and golang.org/x/sys packages (go-txfile requires more recent version).
The update fixes a number of Windows related bugs in spooling to disk and replaces a call to fsync with fcntl+F_FULLFSYNC on darwin.
The error messages generated by go-txfile will be more detailed. We will further improve error handling and error reporting in the spool in follow up PRs.
The changes to Changelog.asciidoc for all user visible fixes and improvements.