Fix Grok pattern of MongoDB module #7568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Jul 11, 2018
| @@ -100,6 +100,7 @@ https://github.com/elastic/beats/compare/v6.2.3...master[Check the HEAD diff] | |||
| - Optimize PostgreSQL ingest pipeline to use anchored regexp and merge multiple regexp into a single expression. {pull}7269[7269] | |||
| - Fix offset field pointing at end of a line. {issue}6514[6514] | |||
| - Fix an issue when parsing ISO8601 dates with timezone definition {issue}7367[7367] | |||
| - Fix MongoDB Filebeat module. {pull}7568[7568] | |||
There was a problem hiding this comment.
Can you be more specific on what was fixed? It seems it worked for most of the log lines and only didn't match a few.
There was a problem hiding this comment.
@kvch Can you update this part here?
ruflin
approved these changes
Jul 11, 2018
|
Can you rebase on master? That should fix the header issue. |
kvch
force-pushed
the
fix/filebeat/add-missing-mongodb-module-logs
branch
from
8c94c4c to
2bd88c6
Compare
ruflin
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the following log line produced an error, because the number of spaces after the component name were limited to two in the pattern.
In case of this line the parsing failed, because after
"FTDC"there are more than two space due to padding. From now on arbitrary number of spaces are allowed, so padding won't cause any problem.Ohter minor changes regarding testing: