Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation fileset for Elasticsearch filebeat module #7474

Merged
merged 7 commits into from
Jul 2, 2018

Conversation

immon
Copy link
Contributor

@immon immon commented Jun 29, 2018

No description provided.

@immon immon requested a review from ruflin June 29, 2018 13:30



*`elasticsearch.deprecation.component`*::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this component the same used across all elasticsearch logs? I wonder if we should have a generic field for it if yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, exactly. it is the same.
Deprecation fileset is very similar to server fileset. We could merge those two. We still probably want to mark one logfiles as server log and the other as deprecation log.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Elasticsearch create a log file for each? If yes, we should keep 2 filesets.

For sharing code: No easy way to do this yet but I can look into it if we have more similar cases in the future.

Any suggestion on how we should call the field? Just elasticsearch.component. I feel like there should be something before component. Is it server?

return errors.Wrap(CreateSHA512File(spec.OutputFile), "failed to create .sha512 file")
}

func addUidGidEnvArgs(args []string) ([]string, error) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func addUidGidEnvArgs should be addUIDGidEnvArgs

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Waiting for green CI.

@ruflin ruflin merged commit 11d2a64 into elastic:master Jul 2, 2018
@immon immon deleted the es-module-deprec-fileset branch July 10, 2018 12:47
@tsg tsg mentioned this pull request Jul 16, 2018
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants