-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation fileset for Elasticsearch filebeat module #7474
Conversation
filebeat/docs/fields.asciidoc
Outdated
|
||
|
||
|
||
*`elasticsearch.deprecation.component`*:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this component the same used across all elasticsearch logs? I wonder if we should have a generic field for it if yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, exactly. it is the same.
Deprecation fileset is very similar to server fileset. We could merge those two. We still probably want to mark one logfiles as server log and the other as deprecation log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Elasticsearch create a log file for each? If yes, we should keep 2 filesets.
For sharing code: No easy way to do this yet but I can look into it if we have more similar cases in the future.
Any suggestion on how we should call the field? Just elasticsearch.component
. I feel like there should be something before component
. Is it server
?
dev-tools/mage/pkgtypes.go
Outdated
return errors.Wrap(CreateSHA512File(spec.OutputFile), "failed to create .sha512 file") | ||
} | ||
|
||
func addUidGidEnvArgs(args []string) ([]string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func addUidGidEnvArgs should be addUIDGidEnvArgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Waiting for green CI.
No description provided.