Fix system process CPU ticks field mapping #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
review
Metricbeat
Enabling `process.include_cpu_ticks: true` would cause an Elasticsearch mapping conflict because the `.ticks` fields for user and system were not defined in the fields.yml.
andrewkroh
force-pushed
the
bugfix/mb/system-process-ticks
branch
from
dd006dd to
7f33134
Compare
|
Shouldn't we add some tests that expose the original issue to make sure this doesn't happen again? |
By enabling the feature we will automatically be ensuring that the fields in the event are also in the fields.yml.
|
@ctindel I was thinking the same thing. I updated the test case for the process metricset. It ran the updated test case without the fix and it failed (e.g. |
|
Well done! |
|
@andrewkroh do you know which point release this will ship in? |
|
@andrewkroh I did a rebase merge on this as it had 2 clean commits with description. But after merging I realised it would have been better as 1 commit because of the backport :-( |
andrewkroh
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
process.include_cpu_ticks: truewould cause an Elasticsearch mapping conflict because the.ticksfields for user and system were not defined in the fields.yml.