Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update state_container to latest kube-state-metrics version #7216

Merged
merged 3 commits into from
Jun 4, 2018
Merged

Update state_container to latest kube-state-metrics version #7216

merged 3 commits into from
Jun 4, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented May 30, 2018 •
edited
Loading

This PR updates state_container metricset to latest kube-state-metrics version:

  • Support renamed total restarts field
  • Add termination/waiting reason field

Closes #6638 #6639

@exekias exekias force-pushed the update-state_container-restarts branch 5 times, most recently from c5b1e3f to de26b3f Compare May 31, 2018 10:15
@exekias exekias added review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. v6.3.0 labels May 31, 2018
ruflin
ruflin reviewed Jun 1, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. +1 on making things lower case.

The part I didn't fully get is when we apply it and when not? Is any of the fields different from the last release, meaning we need a changelog entry?

Needs another rebase.

Carlos Pérez-Aradros Herce added 3 commits June 4, 2018 11:25
Update state_container to latest kube-state-metrics version
88781d2 
kube_pod_container_status_restarts has been renamed to kube_pod_container_status_restarts_total

Old fields is kept to support older versions
Add waiting/termination reason field
3b8ed95
Update CHANGELOG.asciidoc
6607d07
@exekias
Copy link
Contributor Author

exekias commented Jun 4, 2018 •
edited
Loading

I kept old fields lowercase, for two reasons: they are mostly 1 word + we avoid a breaking change. The field that keeps case is new with this PR (kubernetes.container.status.reason), its values have normally more than one word: ContainerCreating, CrashLoopBackoff, ErrImagePull... Lowercase looks really awful there.

I rebased and added a changelog :)

@exekias exekias force-pushed the update-state_container-restarts branch from de26b3f to 6607d07 Compare June 4, 2018 09:32
@ruflin
Copy link
Contributor

ruflin commented Jun 4, 2018

jenkins, test this

@ruflin ruflin merged commit c522340 into elastic:master Jun 4, 2018
@exekias exekias removed needs_backport PR is waiting to be backported to other branches. v6.3.0 labels Jun 8, 2018
@f0
Copy link
Contributor

f0 commented Jul 26, 2018

@ruflin @exekias is this in 6.3.2?

@ruflin
Copy link
Contributor

ruflin commented Jul 27, 2018

This didn't make it into the 6.3 release but it will be in the upcoming 6.4 release.

@exekias exekias mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin left review comments

Assignees
No one assigned
Labels
Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exekias @ruflin @f0