Add response fields to Kibana module based on ECS #7205
Conversation
ruflin
added
in progress
ruflin
force-pushed
the
enhance-kibana-module
branch
from
86b46b3 to
850f35a
Compare
filebeat/_meta/fields.common.yml
Outdated
| HTTP response status_code. | ||
| example: 404 | ||
|
|
||
| - name: http.response.time |
There was a problem hiding this comment.
I'm not happy with the naming of this field as it's more the duration of the request and does not directly belong to the response?
There was a problem hiding this comment.
This is probably what we have in heartbeat under http.rtt.total: https://github.com/elastic/beats/blob/master/heartbeat/monitors/active/http/_meta/fields.yml#L85
There was a problem hiding this comment.
I think the term "response time" is pretty ubiquitous so wouldn't change it. IIUC this field contains the elapsed time between request received to responses sent by the Kibana server. So if anything you could work in "elapsed" to the name to emphasize that this is a duration rather that a date (e.g. http.response.elapsed_time).
There was a problem hiding this comment.
I like the suggestion, changed to elapsed_time
ruflin
force-pushed
the
enhance-kibana-module
branch
from
850f35a to
18961a5
Compare
ruflin
force-pushed
the
enhance-kibana-module
branch
2 times, most recently
from
973c3b1 to
8232b72
Compare
ruflin
force-pushed
the
enhance-kibana-module
branch
2 times, most recently
from
dbdb26f to
a0d409b
Compare
ruflin
force-pushed
the
enhance-kibana-module
branch
from
a0d409b to
0c04499
Compare
This is based on the ECS http fields: https://github.com/elastic/ecs#http
ruflin
force-pushed
the
enhance-kibana-module
branch
from
0c04499 to
faf16a5
Compare
This is based on the ECS http fields: https://github.com/elastic/ecs#http