Error out on invalid Autodiscover template conditions settings #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
reviewed
May 29, 2018
libbeat/autodiscover/autodiscover.go
Outdated
| @@ -54,7 +56,7 @@ func NewAutodiscover(name string, pipeline beat.Pipeline, adapter Adapter, confi | |||
| for _, providerCfg := range config.Providers { | |||
| provider, err := Registry.BuildProvider(bus, providerCfg) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, errors.Wrap(err, "Error in autodiscover provider settings") | |||
exekias
force-pushed
the
autodiscover-error-bad-condition
branch
5 times, most recently
from
f3ee3a6 to
280b257
Compare
exekias
force-pushed
the
autodiscover-error-bad-condition
branch
from
280b257 to
c7c8e02
Compare
exekias
added
review
and removed
in progress
|
This one should be ready for review |
|
@exekias Is there a way to trigger the bug via a unit test? |
exekias
force-pushed
the
autodiscover-error-bad-condition
branch
from
8f2ce0b to
4b62b41
Compare
|
👍 added some more tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7183