Comply with PostgreSQL database name format #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
force-pushed
the
fix/filebeat/postresql-module-db-name
branch
from
592a9ae to
914dbc0
Compare
Codecov Report
@@ Coverage Diff @@
## master #7198 +/- ##
=========================================
- Coverage 64.78% 64.5% -0.28%
=========================================
Files 769 769
Lines 47826 47826
=========================================
- Hits 30984 30852 -132
- Misses 13925 14075 +150
+ Partials 2917 2899 -18
Continue to review full report at Codecov.
|
|
jenkins test this please |
ruflin
approved these changes
May 30, 2018
kvch
force-pushed
the
fix/filebeat/postresql-module-db-name
branch
from
914dbc0 to
b63462b
Compare
|
Done. |
|
WFG |
|
I think we should backport it to 6.3, I will backport #7269 and I would prefer we don't diverge too much :) |
ph
added
v6.3.1
and removed
needs_backport
ph
pushed a commit
to ph/beats
that referenced
this pull request
Jun 14, 2018
Support `_` and `$` in PostgreSQL database names as all of those are valid characters in a name. Reference: > SQL identifiers and key words must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters in an identifier or key word can be letters, underscores, digits (0-9), or dollar signs ($). Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, so their use might render applications less portable. (Source: https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS) Closes elastic#7195 (cherry picked from commit d21b351)
ruflin
pushed a commit
that referenced
this pull request
Jun 15, 2018
Support `_` and `$` in PostgreSQL database names as all of those are valid characters in a name. Reference: > SQL identifiers and key words must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters in an identifier or key word can be letters, underscores, digits (0-9), or dollar signs ($). Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, so their use might render applications less portable. (Source: https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS) Closes #7195 (cherry picked from commit d21b351)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) Support `_` and `$` in PostgreSQL database names as all of those are valid characters in a name. Reference: > SQL identifiers and key words must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters in an identifier or key word can be letters, underscores, digits (0-9), or dollar signs ($). Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, so their use might render applications less portable. (Source: https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS) Closes elastic#7195 (cherry picked from commit a74f810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
_and$in PostgreSQL database names as all of those are valid characters in a name.Reference:
(Source: https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS)
Closes #7195