Combine Elasticsearch module integration tests #7049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
ruflin
force-pushed
the
unify-es-tests
branch
2 times, most recently
from
39d463a to
d1790db
Compare
This combines all Elasticsearch module integration tests on the module level. This has the advantage that it removes duplicated code and makes adding a metricset to the test very simple. Also data generators was move to the module level to have it one place. It also should speed up tests as Elasticsearch has to be started only once. As package name `elasticsearch_test` is used to make sure tests happen inside it's own package. For the data generation a path was introduced to still write the data files into the correct directory.
jsoriano
reviewed
May 9, 2018
| return nil | ||
| } | ||
|
|
||
| // WriteEventsReporterV2 fetches events and writes the first event to a ./_meta/data.json | ||
| // file. | ||
| func WriteEventsReporterV2(f mb.ReportingMetricSetV2, t testing.TB) error { | ||
| func WriteEventsReporterV2(f mb.ReportingMetricSetV2, t testing.TB, path string) error { |
There was a problem hiding this comment.
I wonder if the path is going to be most of the times based on the metricset name, because then maybe we could guess it from f.Name() or similar. This would require less knowlegde when writting tests. WDYT?
There was a problem hiding this comment.
It is for all tests which are written on the module level. Not sure yet where we end up here TBH. Ok to simplify this later?
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
This combines all Elasticsearch module integration tests on the module level. This has the advantage that it removes duplicated code and makes adding a metricset to the test very simple. Also data generators was move to the module level to have it one place. It also should speed up tests as Elasticsearch has to be started only once. As package name `elasticsearch_test` is used to make sure tests happen inside it's own package. For the data generation a path was introduced to still write the data files into the correct directory.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
This combines all Elasticsearch module integration tests on the module level. This has the advantage that it removes duplicated code and makes adding a metricset to the test very simple. Also data generators was move to the module level to have it one place. It also should speed up tests as Elasticsearch has to be started only once. As package name `elasticsearch_test` is used to make sure tests happen inside it's own package. For the data generation a path was introduced to still write the data files into the correct directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines all Elasticsearch module integration tests on the module level. This has the advantage that it removes duplicated code and makes adding a metricset to the test very simple. Also data generators was move to the module level to have it one place. It also should speed up tests as Elasticsearch has to be started only once.
As package name
elasticsearch_testis used to make sure tests happen inside it's own package.For the data generation a path was introduced to still write the data files into the correct directory.