Update sarama to release v1.16.0 #7025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
force-pushed
the
upd/sarama-v1.16-patched
branch
from
4fa4988 to
21dd06b
Compare
|
Could you add a CHANGELOG entry? Is this ready for review / merging? |
urso
force-pushed
the
upd/sarama-v1.16-patched
branch
from
577b98c to
d443d97
Compare
- update sarama to v1.16.0 - Use kafka 1.0.0 for testing - add supported kafka versions up to 1.1.0 - Fix lz4 not being configurable - Add unit test on config validation - Separate kafka version definitions
urso
force-pushed
the
upd/sarama-v1.16-patched
branch
from
d443d97 to
9b4b3a8
Compare
Someone can't wait for kafka update? Did some more cleanup, fixes, added some tests and changelog. PR is squashed already. Now it's ready ;) |
urso
added
review
libbeat
and removed
in progress
|
It was just sooo green on CI :-D |
This was referenced May 9, 2018
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
- update sarama to v1.16.0 - Use kafka 1.0.0 for testing - add supported kafka versions up to 1.1.0 - Fix lz4 not being configurable - Add unit test on config validation - Separate kafka version definitions
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
- update sarama to v1.16.0 - Use kafka 1.0.0 for testing - add supported kafka versions up to 1.1.0 - Fix lz4 not being configurable - Add unit test on config validation - Separate kafka version definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.0if version is not configured (default used to be 0.8)