Disable fsnotify recursive test under Darwin #6962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race has been discovered in the kqueue implementation of fsnotify which causes installation of a watch to a subdirectory of an already watched directory to fail occasionally. Disabled the test because Auditbeat doesn't use fsnotify under Darwin, so there is no point on testing it anyway. From an initial investigation it resulted that sometimes a directory creation event from the kernel is received twice. In Auditbeat, we react to the first one by adding a watch to the directory. Once the second event arrives, fsnotify overwrites the watch with an internal one, as it needs to install a watch on every file and directory it monitors.
andrewkroh
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race has been discovered in the kqueue implementation of fsnotify which causes installation of a watch to a subdirectory of an already watched directory to fail occasionally.
Disabled the test because Auditbeat doesn't use fsnotify under Darwin, so there is no point on testing it anyway.
From my investigation it resulted that sometimes a directory creation event from the kernel is received twice. In Auditbeat, we react to the first one by adding a watch to the directory. Once the second event arrives, fsnotify overwrites the watch with an internal one, as it needs to install a watch on every file and directory it monitors. This second watch registers to receive events from the kernel when the directory is moved or deleted, but ignores when files are added to the directory.