Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set stubstatus as default metricset for nginx module #6770

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Set stubstatus as default metricset for nginx module #6770

merged 1 commit into from
Apr 5, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 4, 2018

See #6668

@jsoriano jsoriano requested a review from ruflin April 4, 2018 14:51
@ruflin ruflin mentioned this pull request Apr 4, 2018
Closed
32 tasks
ruflin
ruflin reviewed Apr 4, 2018
View reviewed changes
metricbeat/module/nginx/_meta/config.yml Outdated
@@ -1,6 +1,5 @@
- module: nginx
metricsets: ["stubstatus"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, done.

@jsoriano jsoriano force-pushed the nginx-default-metricset branch from e08641c to 7e56a6d Compare April 4, 2018 15:05
@ruflin ruflin merged commit 15a6462 into elastic:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin left review comments

Assignees
No one assigned
Labels
Metricbeat Metricbeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ruflin