Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Golang module and metricsets as beta #6711

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Mark Golang module and metricsets as beta #6711

merged 2 commits into from
Apr 4, 2018

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Mar 30, 2018

No description provided.

ph
ph approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph
Copy link
Contributor

ph commented Apr 2, 2018

Can you rebase this?

@ruflin
Copy link
Contributor Author

ruflin commented Apr 3, 2018

Done

@kvch
Copy link
Contributor

kvch commented Apr 3, 2018

Changelog still has conflicting changes. :(

@ruflin
Copy link
Contributor Author

ruflin commented Apr 3, 2018

Resolved again, but could happen again on the next merge.

@jsoriano jsoriano merged commit 90af715 into elastic:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruflin @ph @kvch @jsoriano