Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite_keys fix for #6381 #6509

Closed
wants to merge 8 commits into from
Closed

overwrite_keys fix for #6381 #6509

wants to merge 8 commits into from

Conversation

ewgRa
Copy link
Contributor

@ewgRa ewgRa commented Mar 8, 2018

Explanations of bug in original issue #6381

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin ruflin requested a review from urso March 12, 2018 09:13
Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only Event.Meta must be allowed to be nil. If meta is not used by a beat, we should not allocate memory for it.

Not sure we really want to read @metadata fields from inputs json. The @metadata field is somewhat special, as it can be used to control some behavior in the output in beats + control event routing in Logstash.

@Zenexer
Copy link

Zenexer commented Sep 14, 2018

@urso I'm encountering #6381 while attempting to overwrite @metadata. Use case: I want to put data into @metadata that's eventually used to set outputs.elasticsearch.document_id in Logstash.

@kaiyan-sheng
Copy link
Contributor

Hi @ewgRa, seems like there is no update on this PR for a long time. I will close this PR for now and please feel free to open a new PR or reopen this one in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants