Fix for kafka logger #6430
Merged
Fix for kafka logger #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments are passed as slice (v) instead of a argument list (v...) which results in a wrong output in the log
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Just saw the same (but not complete) fix in #6371 |
|
Do you mind rebasing your branch after #6371 is merged, so both of your changes could be merged? |
|
This PR also includes the changes from #6371 |
|
Yes, sorry I've seen it after sending my comment. |
|
jenkins test it |
kvch
approved these changes
Feb 21, 2018
|
Yes from master 2 hours ago. |
|
Thanks for fixing the log messages! |
adriansr
pushed a commit
to adriansr/beats
that referenced
this pull request
May 17, 2018
* Fix for kafka logger The arguments are passed as slice (v) instead of a argument list (v...) which results in a wrong output in the log * Add pull request to CHANGELOG
|
@kvch This seems to be in 6.2. Does it still need to be backported? |
urso
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments are passed as slice (v) instead of a argument list (v...) which results in a wrong output in the log