Backport - DNS over TCP clean-up and improvements #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McStork
changed the title
|
I forgot this on the original PR, can you please add a note to the change log about adding support for the DNS protocol over TCP. |
* Use RFC 1035 'bytes offset' to decode DNS over TCP payloads * Correct Streams management * Improve error management (for Debug and published Notes) * Tests improvement * Split files of ```package dns``` Minor changes: * Change the name of dnsPrivateData to dnsConnectionData to reflect the naming used in other applayers * Split the ```Parse()``` method in multiple functions to comply more with the code convention used in other applayers implementation * Remove a PCAP file from the previous and first DNS over TCP pull request * Introduce a README.md file
* Use printf format in all debug messages * Rename err in handleDecode * Remove a useless pointer assignement and move another one into a if statement
McStork
force-pushed
the
cherry1.1-dns-tcp
branch
from
59c7da4 to
dcd2db3
Compare
|
I think that's about it for the cherry picking. |
andrewkroh
added a commit
that referenced
this pull request
Jan 7, 2016
Backport - DNS over TCP clean-up and improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of DNS over TCP #554 #651