More verbose error logs for collecting monitoring metrics #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
suggested changes
Feb 21, 2018
libbeat/cmd/instance/metrics.go
Outdated
| @@ -149,7 +149,7 @@ func getCPUUsage() (float64, *process.Ticks, error) { | |||
|
|
|||
| totalCPUUsage, ok := iTotalCPUUsage.(float64) | |||
| if !ok { | |||
| return 0.0, nil, fmt.Errorf("error converting value of CPU usage since start") | |||
| return 0.0, nil, fmt.Errorf("error converting value of CPU usage since start to float64") | |||
| } | |||
There was a problem hiding this comment.
Adding the original value of totalCPUUsage to the message would be useful when debugging. Same with the other casting for this PR.
|
We will need that for 6.2 I have added the |
kvch
added a commit
to kvch/beats
that referenced
this pull request
Feb 21, 2018
* libbeat: more info error messages && fixes * libbeat: add variable of failing conversion to message (cherry picked from commit baa740d)
|
I removed the label, as backport pr has been opened. |
kvch
removed
the
needs_backport
ph
pushed a commit
that referenced
this pull request
Feb 21, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…) (elastic#6437) * libbeat: more info error messages && fixes * libbeat: add variable of failing conversion to message (cherry picked from commit e8c6e8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6426