Set up logging -> Configure logging #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roncohen
commented
Jan 25, 2018
roncohen
commented
|
Sure, looks fine. TBH, I want to do more cleanup on this TOC, but it seems like a low priority. I'm not sure any user will be confused, though maybe you're suggesting "configure" because you think it will be better for SEO? If it's the inconsistency you're concerned about, that's true of other topics, too. Although "set up" leaves you fee to cover more than just configuration. |
dedemorton
approved these changes
Jan 25, 2018
|
Since you are in the files already...I am OK with you fixing the problem everywhere. |
|
@roncohen Nevermind, I will just merge and fix the consistency later. thanks! |
|
thanks @dedemorton! I agree there are more inconsistencies. I just saw this as i was working to move it into APM docs. |
dedemorton
added
needs_backport
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Jan 27, 2018
dedemorton
removed
the
needs_backport
ruflin
pushed a commit
that referenced
this pull request
Jan 27, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.