Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up changes in ML importer integration tests #5865

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Follow up changes in ML importer integration tests #5865

merged 2 commits into from
Dec 14, 2017

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Dec 12, 2017

Closes #5863

tsg
tsg approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG.

@andrewkroh
Copy link
Member

Looks like some of the test assertions will need to be adjusted:

15:06:25 --- FAIL: TestImportJobs (0.45s)
15:06:25 	<autogenerated>:1: 
15:06:25                         
15:06:25 	Error Trace:	importer_integration_test.go:168
15:06:25 		
15:06:25 	Error:		Not equal: "87034ms" (expected)
15:06:25 			        != "60s" (actual)

@tsg
Copy link
Contributor

tsg commented Dec 13, 2017

jenkins, retest please

@exekias
Copy link
Contributor

exekias commented Dec 14, 2017

00:08:35.625 ok github.com/elastic/beats/libbeat/ml-importer 1.559s coverage: 63.3% of statements

test is passing now on jenkins, although we have unrelated problems with travis images

@exekias exekias merged commit f1674b5 into elastic:master Dec 14, 2017
@kvch kvch mentioned this pull request Jan 8, 2018
Merged
kvch added a commit to kvch/beats that referenced this pull request Jan 8, 2018
@kvch
Follow up changes in ML importer integration tests (elastic#5865)
b368ed5 
follow up changes in ML importer integration tests

Closes elastic#5863

(cherry picked from commit f1674b5)
ph pushed a commit that referenced this pull request Jan 8, 2018
@kvch @ph
Follow up changes in ML importer integration tests (#5865)
7d6fc1b 
follow up changes in ML importer integration tests

Closes #5863

(cherry picked from commit f1674b5)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kvch @ph
Follow up changes in ML importer integration tests (elastic#5865)
559f384 
follow up changes in ML importer integration tests

Closes elastic#5863

(cherry picked from commit 8ed1432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
bug :ML jobs :Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kvch @andrewkroh @tsg @exekias