Fix missing ACK in redis output #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
reviewed
Oct 25, 2017
| @@ -128,7 +128,10 @@ func (c *client) Publish(batch publisher.Batch) error { | |||
| if rest != nil { | |||
There was a problem hiding this comment.
Question so I would undestand: what does publish only return event if an error occured?
There was a problem hiding this comment.
Now I see what is happening here. I asked too early. :)
There was a problem hiding this comment.
The publish functions do return the events not being published yet. Normally that's true if an error occured. We always return the error value, just in case.
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Oct 27, 2017
(cherry picked from commit 103979f)
exekias
pushed a commit
that referenced
this pull request
Oct 27, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #5404