-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure VM support for add_cloud_metadata processor #5355
Conversation
Can one of the admins verify this patch? |
Thanks a lot for this contribution. Could you adda CHANGELOG entry? |
jenkins, test it |
Thanks @ruflin, where do I add the change log? Under rc1 notes? |
@saada Best add it after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
🎉 Done! |
I just thought of one more thing we need with this change. Can you update the add_cloud_metadata docs to include Azure. |
@andrewkroh done 👍 |
jenkins, test it |
Closes #3784.
Tests pass locally.
Follows the guidelines here: https://docs.microsoft.com/en-us/azure/virtual-machines/linux/instance-metadata-service