Deprecate config_dir (Filebeat) and refactor docs #5321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
review
v6.0.0-rc2
needs_backport
This deprecates the config_dir option in Filebeat, as it's functionality is covered by `filebeat.config.prospectors`. There's a bigger refactoring in the docs, to reflect that the `filebeat.config.*` and `metricbeat.config.*` options can be used for both including external files and live reloading. Only the live reloading part stays in Beta, including external config files is GA. Part of elastic#4581.
tsg
force-pushed
the
deprecate_config_dir
branch
from
fa77c15 to
764a1a4
Compare
dedemorton
reviewed
Oct 4, 2017
|
|
||
| To enable dynamic config reloading, you specify the following options under | ||
| Filebeat can load external configuration files for prospectors and modules, | ||
| which allows you to separate your configuration in multiple smaller |
There was a problem hiding this comment.
Change "separate your configuration in multiple smaller" to "separate your configuration into multiple smaller"
| To enable dynamic config reloading, you specify the following options under | ||
| Filebeat can load external configuration files for prospectors and modules, | ||
| which allows you to separate your configuration in multiple smaller | ||
| configuration files. To use this functionality, use the `path` option from the |
There was a problem hiding this comment.
I wonder if we really need to mention the options here since we describe them more completely later. Might actually be a bit confusing.
Maybe just add links to the sections that follow and say:
To use this functionality, specify the path option when you configure the <<reload-prospector-config,prospector>> or <<reload-module-config,module>>.
BTW, I would probably rename the anchors to load-prospector-config and load-module-config.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Oct 5, 2017
This deprecates the config_dir option in Filebeat, as it's functionality is covered by `filebeat.config.prospectors`. There's a bigger refactoring in the docs, to reflect that the `filebeat.config.*` and `metricbeat.config.*` options can be used for both including external files and live reloading. Only the live reloading part stays in Beta, including external config files is GA. Part of elastic#4581. (cherry picked from commit 396cff7)
ruflin
pushed a commit
that referenced
this pull request
Oct 5, 2017
This deprecates the config_dir option in Filebeat, as it's functionality is covered by `filebeat.config.prospectors`. There's a bigger refactoring in the docs, to reflect that the `filebeat.config.*` and `metricbeat.config.*` options can be used for both including external files and live reloading. Only the live reloading part stays in Beta, including external config files is GA. Part of #4581. (cherry picked from commit 396cff7)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#5331) This deprecates the config_dir option in Filebeat, as it's functionality is covered by `filebeat.config.prospectors`. There's a bigger refactoring in the docs, to reflect that the `filebeat.config.*` and `metricbeat.config.*` options can be used for both including external files and live reloading. Only the live reloading part stays in Beta, including external config files is GA. Part of elastic#4581. (cherry picked from commit 9af1d5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the config_dir option in Filebeat, as it's functionality is
covered by
filebeat.config.prospectors. There's a bigger refactoring in thedocs, to reflect that the
filebeat.config.*andmetricbeat.config.*optionscan be used for both including external files and live reloading. Only the
live reloading part stays in Beta, including external config files is GA.
Part of #4581.