Align kibana index generation to beats standard. #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simitt
commented
Oct 2, 2017
simitt
commented
- Move generator script to dev-tools.
- Add NewGenerator method which returns struct instead of init method.
ruflin
approved these changes
Oct 2, 2017
| func (i *Index) Create() ([]string, error) { | ||
| indices := []string{} | ||
| // Create an instance of the Kibana Index Pattern Generator | ||
| func NewGenerator(indexName, beatName, beatDir, version string) (IndexPatternGenerator, error) { |
There was a problem hiding this comment.
We normally return a reference here, this also make it possible to return nil, err on line 28.
libbeat/kibana/transform.go
Outdated
| keys common.MapStr | ||
| } | ||
|
|
||
| func NewTransformer(timeFieldName, title string, fields common.Fields) Transformer { |
There was a problem hiding this comment.
Same comment as above that we could return a reference. Didn't check if it is required in this case. It seems to work just fine :-)
simitt
force-pushed
the
refactor-generator
branch
from
ab64950 to
fcfe481
Compare
* Move generator script to dev-tools. * Add NewGenerator method which returns struct instead of init method.
simitt
force-pushed
the
refactor-generator
branch
from
fcfe481 to
286399b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.