Add additional php-fpm pool status kpis for Metricbeat module #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@exekias This is the new PR to the master branch |
exekias
reviewed
Oct 2, 2017
| description: > | ||
| Number of seconds since FPM has started. | ||
| - name: start_time | ||
| type: long |
There was a problem hiding this comment.
I think this could be date https://www.elastic.co/guide/en/elasticsearch/reference/current/date.html, you may need to convert the value before pushing it to Elasticsearch
There was a problem hiding this comment.
Sure, it needs a epoch_second format, let me see if I can find how to format that
|
jenkins test it please |
|
@exekias Done |
|
jenkins, test it |
|
@pgilad I think you need to run |
|
@ruflin Thanks, done! |
|
jenkins test it, please |
|
Sorry @pgilad you will also need to update |
|
jenkins test it, please |
|
@pgilad Merged. Thanks a lot for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.