TCP layer drop connection state on gap #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop and reinitialize connection state on gap, so application layer parser will restarted (after detecting gap).
urso
force-pushed
the
fix/342-pgsql-panic
branch
from
95130fc to
4f444b5
Compare
| return TcpStream{}, false | ||
| } | ||
|
|
||
| timeout := time.Duration(0) |
There was a problem hiding this comment.
Out of curiosity, is this form preferred over var timeout time.Duration for any technical reasons?
There was a problem hiding this comment.
ah, copy'n paste. I'd prefer the 'var timeout time.Duration'. but in this case no big difference
|
LGTM |
andrewkroh
added a commit
that referenced
this pull request
Dec 10, 2015
TCP layer drop connection state on gap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop and reinitialize connection state on gap, so application layer parser
will be restarted (after detecting gap).
resolves #342