Scale system.cpu.*.pct metrics by the number of cores #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all `system.cpu.*.pct` metrics to be scaled by the number of CPU cores such that the values range on `[0, 100% * number_of_cores]`. This will make the CPU usage percentages from the system cpu metricset consistent with the system process metricset. The documentation for these metrics already stated that on multi-core systems the percentages could be greater than 100%. This makes the code match the docs, but does cause a change in behavior to the user.
andrewkroh
force-pushed
the
bugfix/5_5-system-cpu-pct-scaled
branch
from
b28d2f2 to
cf45bc6
Compare
tsg
reviewed
Jun 23, 2017
| @@ -6,14 +6,14 @@ | |||
| - name: cores | |||
| type: long | |||
| description: > | |||
| The number of CPU cores. | |||
| The number of CPU cores. The CPU percentages can range from `[0, 100% * cores]`. | |||
There was a problem hiding this comment.
Did you intend to add this here? Is it to explain how is the number of cores useful?
There was a problem hiding this comment.
Yeah, it was intentional (for the reason you mentioned above).
|
Taking it in, to make sure it makes the cut for 5.5.0. |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 23, 2017
Change all `system.cpu.*.pct` metrics to be scaled by the number of CPU cores such that the values range on `[0, 100% * number_of_cores]`. This will make the CPU usage percentages from the system cpu metricset consistent with the system process metricset. The documentation for these metrics already stated that on multi-core systems the percentages could be greater than 100%. This makes the code match the docs, but does cause a change in behavior to the user. (cherry picked from commit 67e2064)
tsg
pushed a commit
that referenced
this pull request
Jun 26, 2017
Change all `system.cpu.*.pct` metrics to be scaled by the number of CPU cores such that the values range on `[0, 100% * number_of_cores]`. This will make the CPU usage percentages from the system cpu metricset consistent with the system process metricset. The documentation for these metrics already stated that on multi-core systems the percentages could be greater than 100%. This makes the code match the docs, but does cause a change in behavior to the user. (cherry picked from commit 67e2064)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all
system.cpu.*.pctmetrics to be scaled by the number of CPU cores such that the values range on[0, 100% * number_of_cores]. This will make the CPU usage percentages from the system cpu metricset consistent with the system process metricset. The documentation for these metrics already stated that on multi-core systems the percentages could be greater than 100%. This makes the code match the docs, but does cause a change in behavior to the user.