Do not activate memcache by default (#4335) #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
|
@zecke Can you add a changelog line, please? Thanks for the fix! |
The documentation states that the memcache proto can be disabled by commenting out the list of ports. In practice one had to comment out the entire line. Fix it by not initializing the Ports variable inside the defaultConfig of the memcache proto. No other proto has Ports initialized in the defaultConfig.
|
Does the test failure look unrelated to you? I don't seem to be able to restart the job, can you? |
|
jenkins, test it |
ruflin
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that the memcache proto can be disabled
by commenting out the list of ports. In practice one had to comment
out the entire line.
Fix it by not initializing the Ports variable inside the
defaultConfig of the memcache proto. No other proto has Ports
initialized in the defaultConfig.